Set clang-format to always left align references and pointers #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjasny
reviewed
Mar 30, 2022
.clang-format
Outdated
| @@ -1 +1,3 @@ | |||
| BasedOnStyle: Google | |||
| DerivePointerAlignment: false | |||
| PointerAlignment: Left | |||
There was a problem hiding this comment.
Could you please remove the explicit PointerAlignment here? It seems to be the default:
$ clang-format --style=Google -dump-config|grep PointerAlign
DerivePointerAlignment: true
PointerAlignment: Left
ljbade
force-pushed
the
ljbade/clang-format
branch
from
16e64f7 to
a89bd23
Compare
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on our fork I noticed an annoying issue where clang-format wasn't consistently left aligning references and pointers. I only noticed this as our own code uses right aligned style so I was doing that by habit until I noticed the a mix of alignment.
It seems by default
clang-formatwill try to derive the alignment based on what it finds already in a file. I changed the.clang-formatto force always left aligned and it found a few files with mixed alignment.