Fix update at zero cpu #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ent' didn't exist in 'data'. Previously, the update would _also_ be skipped if cpuPercent was zero, which would result in the CPU usage only begin updated _during_ execution of a cell (when CPU usage is non-zero), and it would never return to zero afterwards.
Author
|
Oh, I see my PR branched from a master that contained other changes as well. Let me redo this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered what seems to be a bug in
jupyter-resource-usage. The CPU percentage would not be updated, unless we were actually executing code. The result of this was that, after cells had completed and the CPU was idling (0% CPU usage), the displayed percentage would be stuck at the last non-zero value.I traced the cause to this line. Most likely, the intend there was to make sure the CPU usage wasn't displayed if the API endpoint didn't register a CPU usage (i.e. if
datadidn't contain thecpu_percentkey). However,if (cpuPercent)also evaluates toFalsein Javascript ifcpuPercent=0. That caused the lack of updates whenevercpuPercent=0.The current fix explicitly checks if they keyword was found by checking that
data[cpu_percent]was not equal to theundefinedconstant.