Skip to content

Conversation

@krassowski
Copy link
Collaborator

@krassowski krassowski commented Nov 20, 2025

  • Add a failing test case for granular modifications
  • Fix the issue by granularly updating the cells

References:

Before

Screencast.From.2025-11-20.15-04-12.mp4

After

Screencast.From.2025-11-20.15-02-43.mp4

@krassowski krassowski added the bug Something isn't working label Nov 20, 2025
@krassowski krassowski force-pushed the granular-cell-updates branch from 3e26f0a to 5c715dd Compare November 20, 2025 14:17
@krassowski krassowski marked this pull request as ready for review November 20, 2025 15:12
old_cell = self._cell_to_py(old_ycell)
if old_cell == new_cell:
updated_granularly = self._update_cell(
old_cell=old_cell, new_cell=new_cell, old_ycell=old_ycell
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just pass old_ycell, since old_cell can be created from it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about doing that, but we are still using old_cell in line 270 below

Co-authored-by: David Brochart <david.brochart@gmail.com>
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@krassowski krassowski merged commit 91d2742 into jupyter-server:main Nov 20, 2025
22 checks passed
@krassowski krassowski deleted the granular-cell-updates branch November 20, 2025 20:47
@krassowski
Copy link
Collaborator Author

I will release this as v3.3.0 along with #359 - minor bump since the other PR increased required Python version to 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants