-
Notifications
You must be signed in to change notification settings - Fork 22
Fix cell modifications causing cell output reload and shift to active cell index #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cell modifications causing cell output reload and shift to active cell index #360
Conversation
Update tests to expect specific events
3e26f0a to
5c715dd
Compare
| old_cell = self._cell_to_py(old_ycell) | ||
| if old_cell == new_cell: | ||
| updated_granularly = self._update_cell( | ||
| old_cell=old_cell, new_cell=new_cell, old_ycell=old_ycell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just pass old_ycell, since old_cell can be created from it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about doing that, but we are still using old_cell in line 270 below
Co-authored-by: David Brochart <david.brochart@gmail.com>
davidbrochart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
I will release this as |
References:
touch(out of band changes) jupyterlab/jupyterlab#18100 (comment)Before
Screencast.From.2025-11-20.15-04-12.mp4
After
Screencast.From.2025-11-20.15-02-43.mp4