Hard-reload a cell if its outputs change and include stream
#362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
changed the title
Collaborator
Author
|
Maybe we can instead implement outputs handling here. It looks like it would be a minimal change. |
Collaborator
Author
I attempted that in main...krassowski:jupyter_ydoc:implement-outputs-creation but it was not enough - we would need more changes on the frontend. In the meantime I think the best short-term strategy is to perform a hard-reload on cells if outputs changed and the new value includes a stream type output. |
davidbrochart
approved these changes
Nov 21, 2025
Collaborator
davidbrochart
left a comment
davidbrochart
left a comment
There was a problem hiding this comment.
Yes I think it requires changes in the frontend.
krassowski
changed the title
stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
(+) the changes from running cell get written to the output
(-) these are not propagated back correctly and subsequent reloads from disk lead to an inconsistent state
Screencast.From.2025-11-21.11-17-01.mp4
After
(+) no inconsistent state
(-) reload of outputs from disk means that subsequent writes are not respected
Screencast.From.2025-11-21.11-15-21.mp4