Skip to content

Conversation

@kevin-bates
Copy link
Member

The method to handle conditional returns of futures in tornado was both deprecated and incompatible with asyncio. This incompatibility surfaces with Notebook 6.1 since it uses asyncio. Now using maybe_future from notebook.utils instead.

Updated the python matrix in Travis.

Fixes #337

@kevin-bates kevin-bates requested a review from lresende August 10, 2020 16:15
Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should really look into transitioning users to EG which has been merged with JKG and supports both local and remote kernels.

@kevin-bates
Copy link
Member Author

Thanks for the review @lresende.

we should really look into transitioning users to EG which has been merged with JKG and supports both local and remote kernels

True, but EG doesn't support the http personality: --KernelGatewayApp.api='kernel_gateway.notebook_http' so JKG is still necessary for that.

@kevin-bates kevin-bates merged commit b4c8632 into jupyter-server:master Aug 10, 2020
@kevin-bates kevin-bates deleted the fix-maybe-future branch August 10, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POST api/kernel return 'Kernel does not exist'

2 participants