use get_shell_msg helper method #368
Conversation
| if self.parent.personality.should_seed_cell(code): | ||
| client.execute(code) | ||
| msg = client.shell_channel.get_msg(block=True) | ||
| msg = client.get_shell_msg(block=True) |
There was a problem hiding this comment.
I think the block=True needs to be removed.
@davidbrochart - Should we update the migration guide to indicate what calls using block=True should do since we only address the block=False case wrt to a timeout value? I found removing the block=True to be successful but am not entirely sure.
There was a problem hiding this comment.
block=True was the default value, so it could have been omitted previously. It translates to a value of timeout>0 now, which is the default value, so there's nothing to do, and block=True just has to be removed. We can clarify this in the migration guide, and also state that using e.g. client.get_shell_msg() should be used instead of client.shell_channel.get_msg(). I opened jupyter/jupyter_client#685.
|
Hi @tschaume - I went ahead and pushed the change to remove the Once this is merged, I'd like to cut 2.5.1. |
3 participants
fixes #367