Skip to content

Conversation

@xiangmeng4geo
Copy link
Contributor

Add gaode basemap

@davidbrochart
Copy link
Member

Thanks! It looks like your commit isn't linked to your GitHub account. Maybe you want to fix it before merging?
See https://docs.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address

@xiangmeng4geo
Copy link
Contributor Author

Thanks! It looks like your commit isn't linked to your GitHub account. Maybe you want to fix it before merging?
See https://docs.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address

Maybe I forgot to verify my email before. It has been fixed. If it's still a problem with account, leave it alone.

@davidbrochart
Copy link
Member

Do you want to reopen this PR and force-push a new commit?

@xiangmeng4geo xiangmeng4geo reopened this Aug 24, 2020
@xiangmeng4geo
Copy link
Contributor Author

Do you want to reopen this PR and force-push a new commit?

yes

@davidbrochart
Copy link
Member

Do you want to push a new commit with your fixed GitHub ID?

@martinRenou
Copy link
Member

It might not be required to fix the commit, you might just need to add your meng******@moji.com address to your Github account, it was the address used during the commit.

I recall there is no need for validation for it to work (I did it once with an address that did not exist anymore and it worked).

@xiangmeng4geo
Copy link
Contributor Author

No I don`t want. Thanks.

@xiangmeng4geo
Copy link
Contributor Author

I use global git email on my working computer,which been set to our company git address,so I think that`s all right.

@davidbrochart davidbrochart merged commit ac65482 into jupyter-widgets:master Aug 25, 2020
@davidbrochart
Copy link
Member

Thanks!

martinRenou added a commit that referenced this pull request Sep 23, 2020
* Bump elliptic from 6.5.2 to 6.5.3 in /js

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.2...v6.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

* Added better way to update GeoJSON data

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* fixed tooltip popup for title of marker (#677)

* fixed tooltip popup for title of marker

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* Made changes as per review comments

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* Added WKT layer to view WKT data on map (#679)

* Added WKT layer to view WKT data on map

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* Documentation changes for WKT and changes as per review comments

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* refactored code as per comments to use list comprehension

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* Add dependency of shapely (#683)

* Add dependency of shapely separately as geopandas is not dependency

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* removed latest version pin from shapely

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* Revert "fixed tooltip popup for title of marker (#677)"

This reverts commit 118ee5c.

* add gaode (#681)

Co-authored-by: meng.xiang <meng.xiang@moji.com>

* Made default value of zoom trait for SearchControl None so it will not change by default

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* Added example notebooks for KML and GPX file formats

Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>

* Bump node-fetch from 2.6.0 to 2.6.1 in /js

Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Update xleaflet URL

* Update environment.yml

Pin nodejs version, for #699

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kharude, Sachin <sachin.kharude@here.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: sachin kharude <sackh@users.noreply.github.com>
Co-authored-by: 向蒙 <379303813@qq.com>
Co-authored-by: meng.xiang <meng.xiang@moji.com>
Co-authored-by: Sylvain Corlay <sylvain.corlay@gmail.com>
Co-authored-by: banjaxedben <bkinsella@advantech-bb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants