Declare more TS typings

[vidartf]

The current typescript code has a lot of anys (both explicit and implicit). These should be more explicitly typed, at least on the exported functions. A more explicit typing, maybe together with strict null checks might also reveal some bugs.

• no explicit any typings unless absolutely necessary
• no implicit any typings unless necessary
• turn on strict null checking

[jasongrout]

Sounds like an excellent sprint day project.

…

On Thu, Aug 24, 2017, 07:12 Vidar Tonaas Fauske ***@***.***> wrote: The current typescript code has a lot of anys (both explicit and implicit). These should be more explicitly typed, at least on the exported functions. A more explicit typing, maybe together with strict null checks might also reveal some bugs. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1672>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALwZudyNRuv2mZ90yNfbH7cfegDHkUAks5sbVqtgaJpZM4PBPGA> .

[vidartf]

Yes, absolutely. If anybody wants to do it, that would be perfect, if not, I'll try to squeeze it in 😉

[cnishina]

Currently working on this. 😄

[cnishina]

Here is the examples that needs review. #1733

[vidartf]

@cnishina I did some work previously that stranded a bit, see #1734. Always meant to come back to it, but you know how it goes. If you are able to use that as a starting point to take further that would be awesome!

[cnishina]

@vidartf ☹️ I'm having some weird tsc errors that I did not get a few days ago. So I did an npm install in the main directory. I get the following error:

> @jupyter-widgets/base@1.0.2 build:src /path/to/ipywidgets/packages/base
> tsc --project src

src/utils.ts(14,8): error TS2307: Cannot find module 'base64-js'.

That's weird, so I did an npm install -D @types/base64-js to add the typings from DefinitelyTyped. Then I get another error:

> @jupyter-widgets/controls@1.0.2 build:src /path/to/ipywidgets/packages/controls
> tsc --project src

src/phosphor/accordion.ts(10,8): error TS2307: Cannot find module '@phosphor/signaling'.
src/phosphor/currentselection.ts(14,8): error TS2307: Cannot find module '@phosphor/signaling'.
src/phosphor/tabpanel.ts(14,8): error TS2307: Cannot find module '@phosphor/signaling'.

Super weird. I did a brand new clone, install and came up with the same sort of errors. Is there something that I'm missing in the developer setup?