Skip to content

DeprecationWarning for traits arguments from traitlets 4.1 #236

@glyg

Description

@glyg

Hi,

Thank's a lot for this lib, it works like a charm.

Running a CI job on gitlab, I noticed my code, invoking pythreejs through ipyvolume, rises a lot of deprecation warnings such as the following:

/opt/conda/envs/tyssue/lib/python3.6/site-packages/pythreejs/traits.py:55
  /opt/conda/envs/tyssue/lib/python3.6/site-packages/pythreejs/traits.py:55: DeprecationWarning:
Traits should be given as instances, not types (for example, `Int()`, not `Int`) 
Passing types is deprecated in traitlets 4.1.

The same warning is raised for:

Same warning is raised in ipyvolume in some places.

The fix seems quite straightforward, I can open a PR if you wish.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions