Skip to content

Revert the change to parsing in JUPYTER_NO_CONFIG in #199 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Revert the change to parsing in JUPYTER_NO_CONFIG in #199 #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jupyter_core/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def main():
print("JUPYTER_PREFER_ENV_PATH is not set, making the user-level path preferred over the environment-level path for data and config")

# config path list
if paths.envset('JUPYTER_NO_CONFIG'):
if env.get('JUPYTER_NO_CONFIG'):
print("JUPYTER_NO_CONFIG is set, making the config path list only a single temporary directory")
else:
print("JUPYTER_NO_CONFIG is not set, so we use the full path list for config")
Expand Down
4 changes: 2 additions & 2 deletions jupyter_core/paths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def jupyter_config_dir():
env = os.environ
home_dir = get_home_dir()

if envset('JUPYTER_NO_CONFIG'):
if env.get('JUPYTER_NO_CONFIG'):
return _mkdtemp_once('jupyter-clean-cfg')

if env.get('JUPYTER_CONFIG_DIR'):
Expand Down Expand Up @@ -200,7 +200,7 @@ def jupyter_config_path():
If the JUPYTER_PREFER_ENV_PATH environment variable is set, the environment-level
directories will have priority over user-level directories.
"""
if envset('JUPYTER_NO_CONFIG'):
if os.environ.get('JUPYTER_NO_CONFIG'):
# jupyter_config_dir makes a blank config when JUPYTER_NO_CONFIG is set.
return [jupyter_config_dir()]

Expand Down