Allow modifying kernel associated with a session via PATCH #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.assertEqual(changed['id'], sid) | ||
| self.assertEqual(changed['notebook']['path'], 'nb2.ipynb') | ||
|
|
||
| def test_amodify_kernel_name(self): |
|
👍, thanks Min! |
minrk
force-pushed
the
patch-session-kernel
branch
from
df9a2aa to
8cba734
Compare
|
I confirmed this works for me on upcoming PRs to jupyter-js-services and jupyter-js-notebook. |
This was referenced Mar 14, 2016
| kernel_id = yield sm.start_kernel_for_session( | ||
| session_id, kernel_name=kernel_name, path=before['notebook']['path']) | ||
| changes['kernel_id'] = kernel_id | ||
| if 'id' in model['kernel']: |
There was a problem hiding this comment.
I'm sending null if the id is not given, do you mind checking for that here?
|
@minrk, see also the spelling error above. |
- PATCH to kernel.id attaches to other kernel - PATCH to kernel.name starts new kernel with given name Previous kernel is shutdown after the change
minrk
force-pushed
the
patch-session-kernel
branch
from
55db28a to
23b1bea
Compare
minrk
added a commit
that referenced
this pull request
Mar 21, 2016
Allow modifying kernel associated with a session via PATCH
minrk
added a commit
to minrk/notebook
that referenced
this pull request
Apr 13, 2016
…ssion via PATCH - PATCH to kernel.id attaches to other kernel - PATCH to kernel.name starts new kernel with given name Previous kernel is shutdown after the change ...
yuvipanda
pushed a commit
to yuvipanda/notebook
that referenced
this pull request
Jul 26, 2016
…ssion via PATCH - PATCH to kernel.id attaches to other kernel - PATCH to kernel.name starts new kernel with given name Previous kernel is shutdown after the change ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous kernel is shutdown after the change
cc @blink1073