Toggle Header in Edit page #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notebook/templates/edit.html
Outdated
| <span id="kernel_logo_widget"> | ||
| {% block kernel_logo_widget %} | ||
| <img class="current_kernel_logo" src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"/> | ||
| {% endblock %} |
There was a problem hiding this comment.
The changes here to the save widget shouldn't be needed, since they are all notebook-specific.
|
This will be good now. |
|
Great, thanks! It looks like you have a few extra commits that aren't part of this PR. Can you reset to the commit with the real changes here? There are a few ways to do this (rebase, reset). Since it looks like there are a few commits at the end you don't need, you can reset to the real changes with: And then re-push, adding |
|
I think this is good to merge! 👍 |
|
Terrific, thanks @Summersa! |
minrk
added a commit
that referenced
this pull request
Mar 25, 2016
#1214 There is no function to hide the header in edit mode. Now I know my syntax is wrong. I couldn't find a way to do this from the edit page javascript file. If I could get some guidance and than I could write it properly. Right now I just put the javascript within the html edit file. Before: ...
yuvipanda
pushed a commit
to yuvipanda/notebook
that referenced
this pull request
Jul 26, 2016
jupyter#1214 There is no function to hide the header in edit mode. Now I know my syntax is wrong. I couldn't find a way to do this from the edit page javascript file. If I could get some guidance and than I could write it properly. Right now I just put the javascript within the html edit file. Before: ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1214
There is no function to hide the header in edit mode. Now I know my syntax is wrong. I couldn't find a way to do this from the edit page javascript file. If I could get some guidance and than I could write it properly. Right now I just put the javascript within the html edit file.
Before:
#After: