Skip to content

Conversation

@blink1073
Copy link
Contributor

This allows both kernel name and kernel id to be provided in the request, making the request implementation simpler.

cc @minrk

Allow kernel id to take precidence over name

Fix spelling
@blink1073
Copy link
Contributor Author

Motivation: NotebookSession.changeKernel(name: string, id?: string): Promise<IKernel>;. If the id is provided, that should take precedence over name.

@blink1073 blink1073 changed the title Allow kernel id to take precidence over name Allow kernel id to take precedence over name Mar 21, 2016
@minrk minrk added this to the 5.0 milestone Mar 21, 2016
minrk added a commit that referenced this pull request Mar 21, 2016
Allow kernel id to take precedence over name
@minrk minrk merged commit 7174d9d into jupyter:master Mar 21, 2016
@minrk
Copy link
Member

minrk commented Mar 21, 2016

👍

minrk added a commit to minrk/notebook that referenced this pull request Apr 13, 2016
This allows both kernel name and kernel id to be provided in the request, making the request implementation simpler.
@minrk minrk modified the milestones: 4.2, 5.0 Apr 13, 2016
yuvipanda pushed a commit to yuvipanda/notebook that referenced this pull request Jul 26, 2016
This allows both kernel name and kernel id to be provided in the request, making the request implementation simpler.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants