Allow a session to connect to an existing kernel #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
changed the title
blink1073
changed the title
|
This is ready for review. I allowed it to use the kernel name if the kernel id is not active, for compatibility with the existing notebook. |
minrk
added a commit
that referenced
this pull request
Mar 21, 2016
Allow a session to connect to an existing kernel
|
Nice! And I think we do want to keep the new-kernel if one doesn't exist, since that should still be the majority use case. |
minrk
added a commit
to minrk/notebook
that referenced
this pull request
Apr 13, 2016
yuvipanda
pushed a commit
to yuvipanda/notebook
that referenced
this pull request
Jul 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.