Backport pull request #1279: Downgraded ipywidget hack #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR jupyter#1279 didn't auto-apply cleanly, so I had to do a manual backport.
minrk
force-pushed
the
backport-widget-hardcode
branch
from
42cf64b to
d542745
Compare
| }) | ||
| // BEGIN HARDCODED WIDGETS HACK | ||
| .then(function() { | ||
| if (!utils.is_loaded('widgets/extension')) { |
There was a problem hiding this comment.
Now it is jupyter-js-widgets/extension. I opened the corresponding PR in master.
|
Thanks @minrk , this looks good |
|
@jdfreder you missed my inline remark. |
|
No I saw it, it's okay, we can backport another. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1279 didn't auto-apply cleanly, so I had to do a manual patch.
Opening as a PR so @jdfreder and @parente can double-check that I didn't miss something from #1279.