Escape file names in attachment headers #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
minrk
added a commit
that referenced
this pull request
Apr 15, 2016
When there are non-ascii characters in notebook file name, i.e., "文件名.ipynb", notebooks cannot be properly downloaded via configurable-http-proxy in [JupyterHub](https://github.com/jupyter/jupyterhub) and an HPE_INVALID_HEADER_TOKEN is reported. After I inspect the headers returned by the notebook, I find that the file name in Content-Disposition header is not escaped, which cause the error in [request module](https://github.com/request/request) of node.js. After escaping the file names, the bug is resolved.
yuvipanda
pushed a commit
to yuvipanda/notebook
that referenced
this pull request
Jul 26, 2016
When there are non-ascii characters in notebook file name, i.e., "文件名.ipynb", notebooks cannot be properly downloaded via configurable-http-proxy in [JupyterHub](https://github.com/jupyter/jupyterhub) and an HPE_INVALID_HEADER_TOKEN is reported. After I inspect the headers returned by the notebook, I find that the file name in Content-Disposition header is not escaped, which cause the error in [request module](https://github.com/request/request) of node.js. After escaping the file names, the bug is resolved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are non-ascii characters in notebook file name, i.e., "文件名.ipynb", notebooks cannot be properly downloaded via configurable-http-proxy in JupyterHub and an HPE_INVALID_HEADER_TOKEN is reported. After I inspect the headers returned by the notebook, I find that the file name in Content-Disposition header is not escaped, which cause the error in request module of node.js. After escaping the file names, the bug is resolved.