fixes problem with disappearing MathJax mglyphs in output areas #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@poke1024 I can confirm that master currently will not render the SVG and that this PR will render it. In testing, I noticed that the less-watch script only recompiles LESS on a file change and not on @Carreau @minrk Feel free to test as well but I think this is ready to merge. |
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows MathML
mglyphswith embedded data to be correctly rendered. This is an important feature for some applications using images embedded in math formulas.To test this PR's change in a Python 3 notebook, use the attached notebook and evaluate all three cells.
Without this PR, the third step's
HTMLwill output nothing. With the CSS change in this PR, an arrow svg will be visible as expected.The second step is necessary to reconfigure MathJax to accept `mglyph' tags with embedded data, which is by default disabled due to Jupyter's safe MathJax mode. I will address this in a separate PR.
mglyph.ipynb.zip