Rename 'resize' event to 'resizeOutput' #1984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongrout
changed the title
minrk
reviewed
Dec 21, 2016
| that.element.height(''); | ||
| } | ||
| that.element.trigger('resize'); | ||
| that.element.trigger('resize.Output'); |
There was a problem hiding this comment.
We scope events to components when they are global events (e.g. on events.trigger('event.Component')). These are events on a specific element, so scoping seems redundant, doesn't it? For instance, you still can't listen for all resize.Output events with this, can you? Is that what you are after?
There was a problem hiding this comment.
What I was after was fixing the bug where 'resize' events bubble up, then are thrown on the window, and are considered window resize events.
We could just as easily change the name from 'resize' to 'resizeOutput'. Thoughts?
|
@jasongrout This now has a merge conflict, can you rebase it? |
This addresses the ‘resize’ event bubbling issue mentioned in https://bugs.jquery.com/ticket/9841#comment:8 by not triggering an event that will bubble up to something unrelated.
@takluyver - done. |
takluyver
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our convention for events has been to scope component events with
.Component, but we didn't do it for some OutputArea events. This is also related to #1985.This is a breaking change (changes the names of events), so targeting 5.x.