Ignore resize events that bubbled up and didn't come from window. #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iggered by a bubbled event. See https://bugs.jquery.com/ticket/9841. In our case, the OutputArea was triggering a ‘resize’ event on its element, which was bubbling up and causing this handler to execute every time an output was appended. This was a pretty big drain on output areas that quickly changed (like for interact widgets), presumably since this function involves a DOM read to get heights.
jasongrout
force-pushed
the
checkresize
branch
from
a62bb1b to
e909afc
Compare
jasongrout
changed the title
minrk
reviewed
Dec 19, 2016
notebook/static/base/js/page.js
Outdated
| $('div#site').height($(window).height() - $('#header').height()); | ||
| // only trigger if the event actually is the window's, not bubbling up. | ||
| // See https://bugs.jquery.com/ticket/9841#comment:8 | ||
| if (!e.target.tagName) { |
There was a problem hiding this comment.
From Travis: e.target is undefined
There was a problem hiding this comment.
From Travis: e.target is undefined
Thanks. I forgot to push my second commit, after I realized that the function is called directly sometimes, without having an event argument.
minrk
added a commit
that referenced
this pull request
Dec 20, 2016
…me from window. See https://bugs.jquery.com/ticket/9841 - we were having a major slowdown in interact widgets because the output areas were triggering a 'resize' event, which was bubbling up to the window object and running a function which required a DOM read. Signed-off-by: Min RK <benjaminrk@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.jquery.com/ticket/9841 - we were having a major slowdown in interact widgets because the output areas were triggering a 'resize' event, which was bubbling up to the window object and running a function which required a DOM read.