Skip to content

Conversation

@takluyver
Copy link
Member

  • Don't call it at import time
  • Don't fail if git isn't available
  • Don't use shell=True to invoke git

Closes gh-2468

@minrk
Copy link
Member

minrk commented May 3, 2017

👍, though I have a vague recollection that shell=True was needed for it to work on Windows.

@minrk minrk merged commit 94a0b8f into jupyter:master May 3, 2017
@takluyver
Copy link
Member Author

I dug into git history, and it appeared to have been shell=True from when it was originally written in IPython - we don't seem to have started with shell=False and then changed it in response to an issue. That doesn't guarantee that it works on Windows, and I also vaguely recall some issues with invoking other things this way, but I think it's worth a try.

@sarathuniverse
Copy link

where to change this shell=true
I mean in which file i can change

@takluyver
Copy link
Member Author

This is a pull request that was already merged. You can see the files that it changed under the 'Files changed' tab at the top.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jupyter notebook not launching - WindowsError[2] : The System cannot find the file specified

4 participants