update CodeMirror #4858
Merged
update CodeMirror #4858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Also fixes jupyter_contrib_nbextensions #1149. |
|
This is a very annoying bug. Lets merge this ASAP? |
blink1073
pushed a commit
that referenced
this pull request
May 7, 2020
The current CodeMirror version incorrectly highlights f-formatted strings which is fixed on latest CodeMirror version. Fixes #4854
blink1073
pushed a commit
that referenced
this pull request
May 7, 2020
This reverts commit f113632.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CodeMirror version incorrectly highlights f-formatted strings, upgrading solves the problem
Fixes #4854