Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
# Our own imports

from setupbase import (
version,
pkg_version,
find_packages,
find_package_data,
check_package_data_first,
Expand All @@ -75,7 +75,7 @@
Read `the documentation <https://jupyter-notebook.readthedocs.org>`_
for more information.
""",
version = version,
version = pkg_version,
scripts = glob(pjoin('scripts', '*')),
packages = find_packages(),
package_data = find_package_data(),
Expand Down
21 changes: 20 additions & 1 deletion setupbase.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,27 @@ def execfile(fname, globs, locs=None):
version_ns = {}
execfile(pjoin(repo_root, name, '_version.py'), version_ns)

version = version_ns['__version__']
def normalized_version(version_info):
"""Normalize version string

Avoids prerelease uploads getting different versions from sdist and bdist,
due to setuptools normalization.
"""
v = '.'.join(map(str, version_info[:3]))
if len(version_info) == 3:
return v
extra = version_info[3]
if extra.startswith(('a', 'b', 'rc')):
sep = ''
else:
sep = '.'
# pip ensures there's number on the end
if not extra[-1].isdigit():
extra += '0'
return v + sep + extra

version = version_ns['__version__']
pkg_version = normalized_version(version_ns['version_info'])

#---------------------------------------------------------------------------
# Find packages
Expand Down