Use PEP 440 prerelease tags #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids mismatch between wheel/sdist upload on PyPI due to setuptools normalization of prerelease tags.
test directly in the version number file, as the version number is likely to be committed before running tests, so we want **really quick failure**.
notebook/_version.py
Outdated
There was a problem hiding this comment.
version_info should be (4, 1, 0, 'b1')
|
I took care of a few of the lasts comments. |
notebook/_version.py
Outdated
There was a problem hiding this comment.
from this line down can be removed
|
One more note about lingering unused code in |
Thanks for your patience ! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fusion between #860 & #862. Test the version number correctness in unit test, normalize it when exec setup.py
closes #842