Skip to content

Last selected styling #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Last selected styling #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notebook/static/notebook/js/notebook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ define(function (require) {
var low = Math.min(i1, i2);
var high = Math.max(i1, i2);
this.get_cells().map(function(cell, index, all){
if( low <= index && index <= high && low !== high){
if( low <= index && index <= high ){
cell.element.addClass(_SOFT_SELECTION_CLASS);
} else {
cell.element.removeClass(_SOFT_SELECTION_CLASS);
Expand Down
9 changes: 3 additions & 6 deletions notebook/static/notebook/less/cell.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,14 @@ div.cell {
.vbox();
.corner-all();
.border-box-sizing();

border-width: @cell_border_width;
border-style: solid;
border-color: transparent;

width: 100%;
padding: @_cell_padding_minus_border;

/* This acts as a spacer between cells, that is outside the border */
margin: 0px;
outline: none;
Expand Down Expand Up @@ -47,10 +48,6 @@ div.cell {
}
}

&.selected.jupyter-soft-selected {
._selected_style(@selected_border_color, @soft_select_color, 7px, 0);
}

.edit_mode &.selected {
border-color: @edit_mode_border_color;
._selected_style(@edit_mode_border_color, transparent, 5px, 0px);
Expand Down Expand Up @@ -122,7 +119,7 @@ div.unrecognized_cell {
// from text_cell
padding: 5px @_cell_padding_minus_border 5px 0px;
.hbox();

.inner_cell {
.border-radius(@border-radius-base);
padding: @_cell_padding_minus_border;
Expand Down
2 changes: 1 addition & 1 deletion notebook/tests/notebook/multiselect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ casper.notebook_test(function () {
}), 1, 'only one cell is selected programmatically');

this.test.assertEquals(this.evaluate(function() {
return $('.cell.jupyter-soft-selected, .cell.selected').length;
return $('.cell.jupyter-soft-selected').length;
}), 1, 'one cell is selected');

this.test.assertEquals(this.evaluate(function() {
Expand Down