use x-access for directory listing test in is_hidden #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listdir can be slow
|
This makes sense to me, but we're relying on a Unix-y idiom. Have we ensured that whatever it does on Windows produces a sane result? Do we need another check for directory accessibility on Windows? |
access seems to always return True there
|
I tested that it didn't fail on Windows, at least, but after a little more digging I discovered that it just always returns True on Windows, no matter what. Fixed to use stat on Windows, which fails with PermissionDenied on unreadable dirs. |
notebook/utils.py
Outdated
There was a problem hiding this comment.
Should we use os.X_OK | os.R_OK? It's probably not important, but it's possible to have a directory that you can cd into and read files, but not list its contents.
takluyver
added a commit
that referenced
this pull request
Jan 27, 2016
use x-access for directory listing test in is_hidden
minrk
added a commit
that referenced
this pull request
Apr 8, 2016
instead of actually listing because listdir can be slow. closes ipython/ipython#9165
yuvipanda
pushed a commit
to yuvipanda/notebook
that referenced
this pull request
Jul 26, 2016
…s_hidden instead of actually listing because listdir can be slow. closes ipython/ipython#9165
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of actually listing because listdir can be slow.
closes ipython/ipython#9165