Skip to content

fuzzy search #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 3, 2020
Merged

fuzzy search #141

merged 7 commits into from
Nov 3, 2020

Conversation

@jahn96
Copy link
Collaborator

@jahn96 jahn96 commented Oct 22, 2020 •
edited
Loading

  • Use Lumino stringExt to query the matching snippets
  • Fix some issues with preview during searched
  • Bug with highlighting the matched characters
  • Case Insensitive
  • Remove space in search
  • Order the matched snippets based on sum-of-squares scoring algorithm
  • Fix additional bug with filter tag

@jahn96 jahn96 added the enhancement New feature or request label Oct 22, 2020
@jahn96 jahn96 linked an issue Oct 28, 2020 that may be closed by this pull request
Fuzzy Search for Code Snippets #123
Closed
@jahn96 jahn96 self-assigned this Oct 28, 2020
@jahn96 jahn96 requested a review from kpinnipa October 29, 2020 19:27
@jahn96 jahn96 marked this pull request as ready for review October 29, 2020 19:27
@jahn96 jahn96 changed the title [WIP] fuzzy search fuzzy search Oct 29, 2020
kpinnipa
kpinnipa reviewed Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@kpinnipa kpinnipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kpinnipa kpinnipa merged commit ae22891 into jupytercalpoly:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpinnipa kpinnipa kpinnipa left review comments

Assignees

@jahn96 jahn96

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fuzzy Search for Code Snippets

2 participants

@jahn96 @kpinnipa