Alternative model #143
Merged
Alternative model #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated binder link
thegooman
added
the
refactoring
… are very quick on a dataset of 50k rows.
…e for the meantime
…eturning update objects (except setData)
thegooman
approved these changes
Aug 10, 2020
thegooman
pushed a commit
to thegooman/jupyterlab-tabular-data-editor
that referenced
this pull request
Aug 10, 2020
* vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error
ghost
pushed a commit
that referenced
this pull request
Aug 11, 2020
* Create a new csv file from launcher * Row height and scroll bar changes (#170) * Alternative model (#143) * vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error * Code cleanup * Package.json fixed * Comments Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> Co-authored-by: Logan McNichols <loganamcnichols@gmail.com>
Merged
ghost
pushed a commit
that referenced
this pull request
Aug 12, 2020
* Publish 0.4.0 * Shadow/line fixes when moving + handler.ts refactoring (#164) * Spelling/comment fixes * Moving bounded for columns * Moving bounded for rows * Moving to last row/column, minor refactoring * Created computeGridBoundingRegion for refactoring * Commenting updates * Row height and scroll bar changes (#170) * Alternative model (#143) * vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error * Create a new csv file from launcher (#169) * Create a new csv file from launcher * Row height and scroll bar changes (#170) * Alternative model (#143) * vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error * Code cleanup * Package.json fixed * Comments Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> * Selection UX (Insert Below/Right/Moving with Undo/Redo) (#172) * Fixed selection for insert below/right * Fixed selection for moving rows/columns * Handle case where there's no selection * Reselection for undoing a cell edit * Refactoring of the new model (#173) * removed the unused inverse maps from the litestore schema * renamed GridChangeLogArgs to GridState * renamed type ModelChangeType to Commands * renamed some properties of GridState to make it more descriptive * added the grid state to the litestore schema and the updatelitestore function * removed the grid change and the grid change log items from the schema, ModelUpdateArgs, and the updatelitestore function * changed implementations of gridChange in widget.ts to use the gridState.lastChange property instead. * changed lastChange and lastCommand to nextChange and nextCommand because this is more accurate * configured the functions in newmodel to work with the gridState instead of the change and the update log. * began working on the refactoring of the inverseMaps using the state * got the transaction ids set up * set up getting a patch from a transaction id * Finished configuring the inverse map function to use the grid state. * moveRows and moveColumns now add their own nextCommand attribute to the grid state as they are not accessible from widget.ts * Added a check in invertMaps for if there is a nextCommand property. This is how we will distiguish between actions which effect the row/column maps and those which do not. * Made the commands in index.ts plural. E.g. insertRows instead of insertRow. Also, made the signal messages plural to conform with DSVEditor.Commands * made clearRows and clearColumns public methods and moved them to a more appropriate location in newmodel.ts * changed the function clearContents to clearCells to make it more specific. Renamed the command to clearCells as well. * removed the switch statement in clearContents for what region we are on as this is being differentiated into separate commands * created sepearate cases for 'clear-columns' and 'clear-rows' in widget.ts * Changed the modelChangedSignal in widget.ts to have a DSVEditor.Commands attribute in the second slot. Also, fixed some typos in index.ts * added a check in the invertMaps function for if gridState.value is null * added the command to setData to emit to the DSVEditor * started to refactor so that type becomes gridState.nextCommand * widget now updating the gridState with the new command. * Updated the testing suite to reflect the refactor * changed the command descriptions to be pural * Fixing context menu issue (#175) * moved the signal emit in handler.ts so that it gets emitted on a resize. Changed the resize function in widget.ts so that it uses the grid dimensions rather than the viewport dimensions. * fixed the resizing * Edit column-headers (#177) * Save keybinding (#178) * Repo updates (08/03/20 - 08/07/20) (#179) * Updated binder link to latest commit * Create MODEL_CHANGES.md * Update MODEL_CHANGES.md * Added EXPERIMENTAL warning * Update PROGRESS.md * Update PROGRESS.md * Update PROGRESS.md * Ryan's updates * Update PROGRESS.md * Update MODEL_CHANGES.md * Update MODEL_CHANGES.md * Update PROGRESS.md * Update MODEL_CHANGES.md * Update PROGRESS.md * Update README.md * Update PROGRESS.md * Update MODEL_CHANGES.md * Update PROGRESS.md Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> * Publish 0.5.0 Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> Co-authored-by: Logan McNichols <loganamcnichols@gmail.com>
thegooman
pushed a commit
to thegooman/jupyterlab-tabular-data-editor
that referenced
this pull request
Aug 13, 2020
* vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error
ghost
pushed a commit
that referenced
this pull request
Aug 14, 2020
* Alternative model (#143) * vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error * Selection UX (Insert Below/Right/Moving with Undo/Redo) (#172) * Fixed selection for insert below/right * Fixed selection for moving rows/columns * Handle case where there's no selection * Reselection for undoing a cell edit * Repo updates (08/03/20 - 08/07/20) (#179) * Updated binder link to latest commit * Create MODEL_CHANGES.md * Update MODEL_CHANGES.md * Added EXPERIMENTAL warning * Update PROGRESS.md * Update PROGRESS.md * Update PROGRESS.md * Ryan's updates * Update PROGRESS.md * Update MODEL_CHANGES.md * Update MODEL_CHANGES.md * Update PROGRESS.md * Update MODEL_CHANGES.md * Update PROGRESS.md * Update README.md * Update PROGRESS.md * Update MODEL_CHANGES.md * Update PROGRESS.md Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> * Dynamic labels for multi insert/remove * Fixed caption for save * Multi row/column remove * Multi row/column insert * readme Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com>
thegooman
added a commit
that referenced
this pull request
Aug 24, 2020
* 0.5.0 (#180) * Publish 0.4.0 * Shadow/line fixes when moving + handler.ts refactoring (#164) * Spelling/comment fixes * Moving bounded for columns * Moving bounded for rows * Moving to last row/column, minor refactoring * Created computeGridBoundingRegion for refactoring * Commenting updates * Row height and scroll bar changes (#170) * Alternative model (#143) * vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error * Create a new csv file from launcher (#169) * Create a new csv file from launcher * Row height and scroll bar changes (#170) * Alternative model (#143) * vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error * Code cleanup * Package.json fixed * Comments Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> * Selection UX (Insert Below/Right/Moving with Undo/Redo) (#172) * Fixed selection for insert below/right * Fixed selection for moving rows/columns * Handle case where there's no selection * Reselection for undoing a cell edit * Refactoring of the new model (#173) * removed the unused inverse maps from the litestore schema * renamed GridChangeLogArgs to GridState * renamed type ModelChangeType to Commands * renamed some properties of GridState to make it more descriptive * added the grid state to the litestore schema and the updatelitestore function * removed the grid change and the grid change log items from the schema, ModelUpdateArgs, and the updatelitestore function * changed implementations of gridChange in widget.ts to use the gridState.lastChange property instead. * changed lastChange and lastCommand to nextChange and nextCommand because this is more accurate * configured the functions in newmodel to work with the gridState instead of the change and the update log. * began working on the refactoring of the inverseMaps using the state * got the transaction ids set up * set up getting a patch from a transaction id * Finished configuring the inverse map function to use the grid state. * moveRows and moveColumns now add their own nextCommand attribute to the grid state as they are not accessible from widget.ts * Added a check in invertMaps for if there is a nextCommand property. This is how we will distiguish between actions which effect the row/column maps and those which do not. * Made the commands in index.ts plural. E.g. insertRows instead of insertRow. Also, made the signal messages plural to conform with DSVEditor.Commands * made clearRows and clearColumns public methods and moved them to a more appropriate location in newmodel.ts * changed the function clearContents to clearCells to make it more specific. Renamed the command to clearCells as well. * removed the switch statement in clearContents for what region we are on as this is being differentiated into separate commands * created sepearate cases for 'clear-columns' and 'clear-rows' in widget.ts * Changed the modelChangedSignal in widget.ts to have a DSVEditor.Commands attribute in the second slot. Also, fixed some typos in index.ts * added a check in the invertMaps function for if gridState.value is null * added the command to setData to emit to the DSVEditor * started to refactor so that type becomes gridState.nextCommand * widget now updating the gridState with the new command. * Updated the testing suite to reflect the refactor * changed the command descriptions to be pural * Fixing context menu issue (#175) * moved the signal emit in handler.ts so that it gets emitted on a resize. Changed the resize function in widget.ts so that it uses the grid dimensions rather than the viewport dimensions. * fixed the resizing * Edit column-headers (#177) * Save keybinding (#178) * Repo updates (08/03/20 - 08/07/20) (#179) * Updated binder link to latest commit * Create MODEL_CHANGES.md * Update MODEL_CHANGES.md * Added EXPERIMENTAL warning * Update PROGRESS.md * Update PROGRESS.md * Update PROGRESS.md * Ryan's updates * Update PROGRESS.md * Update MODEL_CHANGES.md * Update MODEL_CHANGES.md * Update PROGRESS.md * Update MODEL_CHANGES.md * Update PROGRESS.md * Update README.md * Update PROGRESS.md * Update MODEL_CHANGES.md * Update PROGRESS.md Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> * Publish 0.5.0 Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> * Binder link fix * Unsaved changes dialog (#181) * Added dirty boolean to determined if file has unsaved changes * New dialog added * Launch save dialog, dirty class handling * Refactored moveRows and moveColumns to return objects. (#182) * Refactor/code cleanup with updateLitestore and updateModel. (#183) * refactored widget.ts so that we updateModel executes the litestore updates. Got rid of updateLitestore function. Renamed _modelChanged to _onCommand. Renamed onChangeSignal to commandSignal. litestore.beginTransaction() and litestore.endTransaction() now happens within updateModel. * added return type to bulkSetData * Scroll and select the current match when searching (#184) * Bug fix and code cleanup of handler.ts (#187) * shadow region fixed, still some bugs present * Renamed the bounding region properties and gave them comments to make them less ambiguous. * Cleaned up bound function in selection and added some comments to make it more understandable. * did another renaming of the bounding props so that they would be different from props returned by getBoundingRect * fixed potential issues in computeBoundingRegion * renamed parameters of the IBoundingRegion to make them more understandable. * Bug fixed * Paste bug fix/cut cells refactor (#189) * Paste bug fix * Cut refactor to use clearCells * Publish 0.5.1 * Multi insert/remove for rows/columns (#191) * Alternative model (#143) * vectorized column removing, adding, and moving. Now, these operations are very quick on a dataset of 50k rows. * EditorModel class framework created * data and setData created * all function frameworks written * Added Litestore updates and signals to the grid. * widget.ts connected to newmodel.ts * adding and removing columns and rows now working * row and column add, remove, move working. Generic column headers added. * Undo, redo functionality working. Using personal package tde-datastore for the meantime * cut, copy, paste working * added clear rows method * clearing sorta working * fixed the slow processing in large clearing operations * beginning serializing framework * New approach with inverse arrays * Moved the model's litestore to widget.ts * Got the inverse parameters recorded properly * inverse maps working for removing/adding rows and columns * clearing command working * Created a test suite for newmodel. Refactored so that functions are returning update objects (except setData) * added some tests * bug fixes * ModelChangedArgs simplification * fixed a glitch in one of the tests * fixed replace all * fixed bug with clearing * fixed bugs with large data sets * fixed build error * Selection UX (Insert Below/Right/Moving with Undo/Redo) (#172) * Fixed selection for insert below/right * Fixed selection for moving rows/columns * Handle case where there's no selection * Reselection for undoing a cell edit * Repo updates (08/03/20 - 08/07/20) (#179) * Updated binder link to latest commit * Create MODEL_CHANGES.md * Update MODEL_CHANGES.md * Added EXPERIMENTAL warning * Update PROGRESS.md * Update PROGRESS.md * Update PROGRESS.md * Ryan's updates * Update PROGRESS.md * Update MODEL_CHANGES.md * Update MODEL_CHANGES.md * Update PROGRESS.md * Update MODEL_CHANGES.md * Update PROGRESS.md * Update README.md * Update PROGRESS.md * Update MODEL_CHANGES.md * Update PROGRESS.md Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> * Dynamic labels for multi insert/remove * Fixed caption for save * Multi row/column remove * Multi row/column insert * readme Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> * WCAG AAA approved search colors (#192) * Inserting/removing column bug fixes + refactor (#197) * Bug fix when inserting after last column * Removed model as a parameter for several functions * Bug fix when removing a column that was just inserted * Added return types to several functions * Changed totalRows/totalColumns to getters * Small fixes * Updated tests * Ghost row and column (#196) * ghost row and column added. Handler adding a row and column on a mouse down on a ghost column. * emitting the change signal for an addRows or addColumns from handler.ts * undo and redo sending a signal to update the position of the elements. _updateModel with no update object just moves the elements * added the _ghostRowHeader and _ghostColumnHeader properties * Using technique of placing element over the ghost column and row. * fixed the opacity setting on the elements * added the icons * got highlighting to not be on the ghost column and row. * fixed error with large grids. * added the RichMouseHandlerClass in handler.ts so that we can't tab or enter into a ghost row/column * renamed selection to drag. Created new file called selectionmodel. Added a new class GhostSelectionModel with a modified select method for ghost columns. * added the keyDown signal. Switched to using widgets. * all scrolling signals connected. Ghost column and row working as expected * fixed the css classes so that the opacity set to 0 on hover * Fix the header displaying the wrong value on edit. (#199) * Override of getCellInfo to hopefully fix the issue we were having * emit opposite change now doesn't just default to 'body' on a cells-changed change * DataGrid extended to handle more flexible ui changes. Ghost rows and columns revamped. (#202) * Updated to latest version of tde-datagrid in package.json. * Removed the connections to the scroll bar properties as we are hoping to paint everything directly on the grid. * Created datagrid.ts. Exporting class PaintedGrid which extends DataGrid. * Override of paintContent method added to PaintedGrid. * Added private method _paintAddons to PaintedGrid class for painting amoung other things the ghost row and column. * Began new method _drawGhostRow in PaintedGrid class. * Continued on creating _drawGhostRow. Following a similar pattern to _drawColumnHeaderSection in DataGrid. * Bumped tde-datagrid to version 1.0.10. * Converted dirty rect bounds to cell bounds in _drawGhostRow. * Creating arrays for the column and row sizes. Basically following the pattern in drawBodyRegion. * Simplified code by using the assumption that there is only 1 ghost row. * Bumped tde-datagrid from 1.0.10 to 1.0.11. * Added the PaintedGrid namespace and gave it an exported member ExtraStyle with two properties: ghostRowColor and ghostColumnColor. * Cleared out the ghost widgets from DSVEditor and got rid of methods that we are no longer using. * Changed the DSVEditor's _grid property to a PaintedGrid. * Added convenience getters and setters for the _extraStyle property of the PaintedGrid. * Added extraStyle getters and setters in DSVEditor for the grid. Got rid of old stuff for the ghost widgets in index.ts. Updated index.ts to give each grid an extra style property. Specified a default extra style constant for light mode and dark mode in index.ts. Changed exporting strategy in datagrid.ts so we can get the namespace and the class. * Added a constructor to the PaintedGrid class and gave it a default extraStyle and a slot in IOptions for extraStyle. * Accounted for scrolling in _drawGhostRow. * Added _drawGhostColumn. Changed default color opacities to 0.65. * Added _drawGhostRowHeader and _drawGhostColumnHeader * Added the icons the the column and row headers. * began adding the svg parser api to the grid * Finished writing parseSVG function. * added IIconArgs type and updated default ExtraStyles * canvas drawing API starting to work. * Ghost row and column working using parts of the API. * Set up extra style variables in index.ts for light mode and dark mode. * Console error when searching for a match (#205) * Bug fix with searching * Return types for some functions * Serialization fix for data sets larger than 500 rows. (#206) * Updated tde-csvviewer. * Fixed bugs in parsing data sets of over 500 rows. * Different cell editors for the body region (#188) * Cell data types for the body region * Added toggleSwitch to toolbar * isDataDetection boolean linked to toggle switch * Publish 0.6.0 * Can now edit headers after scrolling. (#210) (#211) * Modified the cell dimensions in the getCellData function. * Fixed the height of the cell container. * Hover opacity change for ghost row and column. (#215) * Hover added to ghost row and column. * Exporting default extra styles so that we only have to update them in one place. * Text alignment for data detection * Center booleans * Fixed error with clear rows & columns. (#216) * Pointer cursor for ghost row/column (#218) * Modified icon painting setup to work with absolute positioning rather than relative positioning. (#219) * Changed the comments in IIconArgs to reflect absolute position rather than relative. Also, changed the defualt styling to reflect this. * Reworked ghost header functions to position the items according to absolute positioning. * Added instructions for resizing the header icons. * Added more instructions. * Ghost row/column fixes (#220) * Adding data detection icons. (#223) * Reworked ghost header functions to position the items according to absolute positioning. * Began working on Icon drawing function. * Updated tde-datagrid. * Wrote the primary function for drawing svgs. * Added icon folder to style. * Added svg.d.ts. * Added the other types of icons to the DEFAULT_LIGHT_STYLE and the DEFAULT_DARK_STYLE. * Data type detection icons working. * Got rid of unnecessary reference to type DataGrid.PaintRegion. * Repo Updates - 08/10 - 08/14 (#221) * Update PROGRESS.md * Update PROGRESS.md * Update PROGRESS.md Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> * Styling for data detection icons (#224) * Updated to latest version of tde-csvviewer. (#226) * Replace all bug fix. (#228) * Updated to latest tde-datagrid. * Fixed bulkSetData. Now return an update object and emitting reset-model. * Test fix (#229) * Fixed testing problems. * Added the style mock. * Added tests. * Makes the text "Column 1" appear on the column header when launching a csv file. (#231) * Added a check in `updateModel` for if the string is empty to add a value to the value map. * moved the location of the check. * Added more tests + refactor (#233) * Fix UI of moving rows & columns (#235) * Fixed issue with move line. * Fixed moving * Selection not updating with replace bug fix. (#232) * Removed await statement and changed this.moveToCell to this.highlightNext() * Fixed the selection count. * Updated tde-datagrid package to 1.0.14. (#239) * Fixed error with painting icons. (#241) * Remove coverage folder from repo (#242) * Remove coverage folder from repo * Remove coverage link * Selection fixed (excludes ghost row/columns). (#243) * Remove unused code blocks. (#245) * New renderer for the header to not overlap with the icons. (#246) * Created a new cell renderer in headercelleditor.ts and now the headers are aligned left with an indent. * Fixed the color change and alignment of the icons. * Publish 0.7.0 * Fixed ghost row icon color * Console error with mousedown * Double-click on ghost row/column fix * Added new files to the demo folder (#248) * Added survey dataset and notebook * Updated customers notebook * Metadata refactor (#250) * meta data type refactor. * Added the number icon to dark mode as well. * Refactor data detection to format data (#251) * Renamed data detection to format data in the toolbar * Renamed isDataDetection boolean to isDataFormatted * Added datatypes demo * Fixed bug with double clicking * Publish 0.7.1 * Tests added. (#253) * Added test for removal. * Added data formatting test. * Added return types. * Boolean checker added to resetMetadata. (#259) * working on bool check. * Added a booly check function and check for boolyness in resetMetadata. * Got rid of the 1 and the 0 * Fixed move error. (#257) * csvviewer package updated + revised 'Column 1' label on launcher (#260) * Updated survey-data notebook (#262) Co-authored-by: Ryan Untalan <untalan.ryan@gmail.com> Co-authored-by: Logan McNichols <loganamcnichols@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request
First step towards the alternative model I outlined.
Issue being fixed:
Fixes #133.
Changes proposed:
Gridnot by making changes to therawDataitself, but by mappingDataGridrequests onto the original location of the requested data.