Configured extension to get it's csvviewer objects from the node pack… #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age tde-csvviewer
ghost
requested a review
from 
thegooman
requested changes
Jul 3, 2020
|
Oh yeah, missed those ones. Got them changed now. |
thegooman
added a commit
to thegooman/jupyterlab-tabular-data-editor
that referenced
this pull request
Jul 3, 2020
jupytercalpoly#30) * Configured extension to get it's csvviewer objects from the node package tde-csvviewer * changed @jupyterlab/csvviewer to tde-csvviewer in index.ts and widget.ts Co-authored-by: Kalen Goo <44537937+kgoo124@users.noreply.github.com>
ghost
pushed a commit
that referenced
this pull request
Jul 3, 2020
* Modified model.ts to create a DSVModel * editable variable in DataGrid is now true Co-authored-by: Logan McNichols <52261474+lmcnichols@users.noreply.github.com> * Added _setField function to setData in the EditableDSVModel * Semi-working editing of cells (text) * Able to edit cells with text * Created CSVTextCellEditor to extend TextCellEditor * Testing (#27) * Modified names of DSV attributes/methods to follow Jupyterlab's standard naming convention for public attributes/methods. Used getters for columnCount and rowCount in place of direct usage of _columnCount and _rowCount attributes * Fixes to package.json (#28) * Modified names of DSV attributes/methods to follow Jupyterlab's standard naming convention for public attributes/methods. Used getters for columnCount and rowCount in place of direct usage of _columnCount and _rowCount attributes * Modified names of DSV attributes/methods to follow Jupyterlab's standard naming convention for public attributes/methods. Used getters for columnCount and rowCount in place of direct usage of _columnCount and _rowCount attributes * Fixed github url in package.json * Configured extension to get it's csvviewer objects from the node pack… (#30) * Configured extension to get it's csvviewer objects from the node package tde-csvviewer * changed @jupyterlab/csvviewer to tde-csvviewer in index.ts and widget.ts Co-authored-by: Kalen Goo <44537937+kgoo124@users.noreply.github.com> * Cell editors always stay the same size as their cell * Changed cell editor text to right align Co-authored-by: Logan McNichols <loganamcnichols@gmail.com> Co-authored-by: Logan McNichols <52261474+lmcnichols@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…age tde-csvviewer
Description of the Pull Request
Modifying extension so that the NPM package tde-csvviewer serves the role that @jupyterlab/csvviewer was serving.
Issue being fixed:
Fixes # 29.
Changes proposed: