tweak language to make clear exec "$@" works
#663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
originally it was: "The last line must be ``exec "$@"`` equivalent." Seemed open to interpretation as I needed to deduce what the equivalent of that would be here. I think adding 'or' before equivalent shows that will work, but I assume other options exist? Or why note say "The last line must be ``exec "$@"``"?
tweak language to make clear `exec "$@"` works
|
I like the suggestion. The "or equivalent" is correct because |
betatim
approved these changes
May 3, 2019
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
tweak language to make clear `exec "$@"` works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally in description of the
startconfig file it read:"The last line must be
exec "$@"equivalent."Seemed open to interpretation as I needed to deduce what the equivalent of that would be here.
I think adding 'or' before 'equivalent' shows that will work, but I assume other options exist? Or why not say "The last line must be
exec "$@""?