Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
974582a
Start Jupyter work
fcollonval Jan 19, 2022
ee972ca
Use outline to highlight button focus, hover and active
fcollonval Jan 19, 2022
a29c5df
Add margin on button to display properly the outline
fcollonval Jan 19, 2022
3af7414
Trial custom button
fcollonval Jan 20, 2022
7961932
Use ts-loader for storybook
fcollonval Jan 24, 2022
21c71d7
Add select
fcollonval Jan 24, 2022
5bf56e0
Fix outline highlight for outline appearance
fcollonval Jan 24, 2022
88c6717
Add fontawesome license
fcollonval Jan 24, 2022
a2313e3
Add text-field
fcollonval Jan 24, 2022
c671b66
Embed more styling
fcollonval Jan 25, 2022
a1b0b18
Tune style for jp-option focus
fcollonval Jan 25, 2022
6ebfb0b
Tune style for jp-select focus
fcollonval Jan 25, 2022
6fbe5cd
Tune style for jp-text-field style
fcollonval Jan 25, 2022
e70bf65
Add minimal attribute to button for toolbar
fcollonval Jan 25, 2022
5d46b69
Add accent choice in toolbar
fcollonval Jan 25, 2022
6554ab1
Add minimal style for select
fcollonval Jan 25, 2022
a147684
Improve border contrast
fcollonval Jan 25, 2022
284faaf
Make minimal more dense
fcollonval Jan 25, 2022
a6b41fe
Upgrade yarn.lock
fcollonval Jan 25, 2022
f05adab
Restore react-component and lab example
fcollonval Jan 25, 2022
cf3b521
Trim CSS variable value before converting it
fcollonval Jan 25, 2022
e890805
Fix linter and add some snapshots
fcollonval Jan 25, 2022
ecfda30
Update all snapshots
fcollonval Jan 25, 2022
5566bfe
Fix MANIFEST.in
fcollonval Jan 25, 2022
011fac0
Fix snapshot
fcollonval Jan 26, 2022
b2e228d
Add slow motion
fcollonval Jan 26, 2022
6e56984
Update snapshots
fcollonval Jan 26, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 5 additions & 51 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: toolkit-ci

on: pull_request
on:
push:
branches: main
pull_request:
branches: main

jobs:
test:
Expand Down Expand Up @@ -34,56 +38,6 @@ jobs:
run: yarn run test
working-directory: packages/components

visual-test:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- name: Checkout 🛎️
uses: actions/checkout@v2

- name: Setup Node 💾
uses: actions/setup-node@v2
with:
node-version: '14'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Setup yarn cache
uses: actions/cache@v2
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
yarn-

- name: Install Dependencies 📥
run: yarn install

- name: Install Playwright Browsers
run: yarn run playwright install --with-deps
working-directory: packages/components

- name: Run Visual Tests 🧪
run: yarn run test:visual
working-directory: packages/components

- name: Update Snapshots
if: ${{ failure() }}
run: |
mv test-results test-assets
yarn run test:visual -u
working-directory: packages/components

- uses: actions/upload-artifact@v2
if: ${{ failure() }}
with:
name: jupyter-ui-test
path: |
packages/components/test-assets/
packages/components/src/**/*-snapshots/*

lint:
runs-on: ubuntu-latest
timeout-minutes: 10
Expand Down
58 changes: 58 additions & 0 deletions .github/workflows/visual-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
name: Toolkit Visual Test

on:
push:
branches: main
pull_request:
branches: main

jobs:
visual-test:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Checkout 🛎️
uses: actions/checkout@v2

- name: Setup Node 💾
uses: actions/setup-node@v2
with:
node-version: '14'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- name: Setup yarn cache
uses: actions/cache@v2
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
yarn-

- name: Install Dependencies 📥
run: yarn install

- name: Install Playwright Browsers
run: yarn run playwright install --with-deps
working-directory: packages/components

- name: Run Visual Tests 🧪
run: yarn run test:visual
working-directory: packages/components

- name: Update Snapshots
if: ${{ failure() }}
run: |
mv test-results test-assets
yarn run test:visual -u
working-directory: packages/components

- uses: actions/upload-artifact@v2
if: ${{ failure() }}
with:
name: jupyter-ui-test
path: |
packages/components/test-assets/
packages/components/src/**/*-snapshots/*
2 changes: 2 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ include packages/components/package.json
include packages/components/jest.config.js
include packages/components/playwright.config.ts
include packages/components/rollup.config.js
include packages/components/tsconfigbase.json
include packages/components/tsconfig.json
include packages/components/tsconfig.storybook.json
graft packages/components/.storybook
graft packages/components/docs
graft packages/components/src
Expand Down
Loading