Defer loading files until after layout restore #4087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-r-rose
reviewed
Mar 2, 2018
| */ | ||
| fromStore(): Promise<void> { | ||
| initialize(isNew: boolean): Promise<void> { | ||
| if (isNew) { |
There was a problem hiding this comment.
I just verified that this change still works with the modelDB in the Google Realtime stuff. I know that's going away soon, but wanted to make sure that we don't do it accidentally.
blink1073
force-pushed
the
simple-context
branch
2 times, most recently
from
bae9ccd to
c16ca7d
Compare
blink1073
force-pushed
the
simple-context
branch
from
e1d07ac to
42af83f
Compare
ian-r-rose
reviewed
Mar 8, 2018
packages/docregistry/src/context.ts
Outdated
| @@ -496,13 +425,109 @@ class Context<T extends DocumentRegistry.IModel> implements DocumentRegistry.ICo | |||
| name, | |||
| language: this._model.defaultKernelLanguage, | |||
| }; | |||
| return this.session.initialize(); | |||
| this.session.initialize(); | |||
There was a problem hiding this comment.
I wonder if we shouldn't even wait on a checkpoint to resolve the ready promise. Thoughts?
There was a problem hiding this comment.
Works for me, updated.
ian-r-rose
reviewed
Mar 9, 2018
Untitled.ipynb
Outdated
| @@ -0,0 +1,44 @@ | |||
| { | |||
There was a problem hiding this comment.
Did you intend to add this file?
|
Thanks! This is a great improvement. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3572.
Summary of changes:
API:
initialize()function toContext(but notIContext) that is used instead of the previoussave()andfromStore()(which was only onContext).whento load contents.Behavioral:
docmananger:opencommand