Fix bindings for remapped modes in Emacs 30 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emacs 30 introduces `major-mode-remap-defaults`, and in particular the auctex remappings are moved to this new variable (from the user option `major-mode-remap-alist`). Hence it is necessary to fix `bind-map--lookup-major-modes` which was added in justbur#9. Emacs 30 also provides the accessor function `major-mode-remap` with the following definition: ```elisp (defun major-mode-remap (mode) "Return the function to use to enable MODE." (or (cdr (or (assq mode major-mode-remap-alist) (assq mode major-mode-remap-defaults))) mode)) ```
Contributor
Author
|
Hi @justbur, would it be possible to review/merge this PR? It addresses syl20bnr/spacemacs#16282, and with the release of Emacs 30 likely imminent, it would be great to have this fixed. Thank you! Edit: I have added an advice to Spacemacs and closed the above issue, but it would of course still be preferable to fix this here. |
fnussbaum
added a commit
to fnussbaum/spacemacs
that referenced
this pull request
Feb 23, 2025
fnussbaum
added a commit
to syl20bnr/spacemacs
that referenced
this pull request
Feb 23, 2025
Owner
|
Thanks and sorry for the delay |
fnussbaum
added a commit
to syl20bnr/spacemacs
that referenced
this pull request
Mar 12, 2025
This reverts commit 9959422, as the relevant fix got merged upstream: justbur/emacs-bind-map#11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs 30 introduces
major-mode-remap-defaults, and in particular the auctex remappings are moved to this new variable (from the user optionmajor-mode-remap-alist). Hence it is necessary to fixbind-map--lookup-major-modeswhich was added in #9.Emacs 30 also provides the accessor function
major-mode-remapwith the following definition: