This repository was archived by the owner on Jul 9, 2023. It is now read-only.
RootCertificate creation improvements #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to implement my own Root certificate storing mechanism as in #175
Since some days ago it was possible to set the RootCertificate from outside, but I'd like to use the existing certification maker classes. (Don't want to reimplement
WinCertificateMakerorBCCertificateMakerin my own code)So I changed the Certification provider to public, which has now 3 public methods:
The default behavior is the same as before, it will store the certificate to rootCert.pfx.
I was also thinking on changing the
ICertificateMakerandCertificateManger.CertEngineto public, too.Maybe it would be useful.
RemoveTrustedRootCertificatesremoves only the root certificates. If you use Bouncy Castle then they are all which are stored in the Windows certmgr.But if you use Windows CertEnroll(is this the right name?) engine, It will store every single site certificate, so later it would be useful to create another cleanup method which removes them.
Doneness: