Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

Conversation

@honfika
Copy link
Collaborator

@honfika honfika commented May 15, 2017

Doneness:

  • Build is okay - I made sure that this change is building successfully.
  • No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of.
  • Branching - If this is not a hotfix, I am making this request against develop branch

/// </summary>
public void Dispose()
{
ServerConnection.Dispose();
Copy link
Owner

@justcoding121 justcoding121 May 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't call this here. Since we reuse this for same client.

So basically we create new HttpWebClient (per session), but we will reuse the server connection.

https://github.com/justcoding121/Titanium-Web-Proxy/blob/develop/Titanium.Web.Proxy/RequestHandler.cs#L407

Until the end of above while loop we reuse the server connection, but note we create new session in each iteration. This server connection reuse was broken (perhaps by my old changes), and I believe this was what causing #184. Adding the client/server connection counts helped me to figure it out.

@honfika
Copy link
Collaborator Author

honfika commented May 15, 2017

Ok, I removed that line, however the proxy seems to work with that:)
Sorry, it is too late here, I'll continue tomorrow.

@honfika
Copy link
Collaborator Author

honfika commented May 15, 2017

I called it because I also added a counter to the CustomBinaryReader class, and it was not disposed properly. After that line it was disposed.

@justcoding121
Copy link
Owner

No problem. I will look at this asap.

@justcoding121 justcoding121 merged commit dff9ef7 into justcoding121:develop May 16, 2017
justcoding121 added a commit that referenced this pull request Oct 18, 2017
reuse buffers, missing dispose added
justcoding121 added a commit that referenced this pull request Oct 18, 2017
reuse buffers, missing dispose added
justcoding121 added a commit that referenced this pull request Oct 19, 2017
reuse buffers, missing dispose added
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants