This repository was archived by the owner on Jul 9, 2023. It is now read-only.
connection count locking + usings sorted #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honfika
commented
May 16, 2017
| Task.WhenAll(handlerTasks).Wait(); | ||
|
|
||
| //why is the sender null? | ||
| ClientCertificateSelectionCallback.InvokeParallel(null, args); |
Collaborator
Author
There was a problem hiding this comment.
Why is the sender null here? It can be the sender parameter of the calling method (which is an SslStream) or the ProxyServer object. (+Same question in ServerCertificateSelectionCallback)
Owner
There was a problem hiding this comment.
Probably I didn't care about it before. We can pass ProxyServer, since SslStream is less useful for doing anything with it.
justcoding121
added a commit
that referenced
this pull request
Oct 18, 2017
connection count locking + usings sorted
justcoding121
added a commit
that referenced
this pull request
Oct 18, 2017
connection count locking + usings sorted
justcoding121
added a commit
that referenced
this pull request
Oct 19, 2017
connection count locking + usings sorted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doneness: