This repository was archived by the owner on Jul 9, 2023. It is now read-only.
move Dispose calls to finally blocks #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Titanium.Web.Proxy/RequestHandler.cs
Outdated
| SessionEventArgs args, bool closeConnection) | ||
| private async Task<bool> HandleHttpSessionRequestInternal(TcpConnection connection, SessionEventArgs args, bool closeConnection) | ||
| { | ||
| bool dispose = true; |
Owner
There was a problem hiding this comment.
should be disposed? I think this should be false by default and then if needs to be disposed we will set it to true. I see some inconsistency in this method.
Collaborator
Author
There was a problem hiding this comment.
The other methods have "disposed" flag, this is "dispose" which means that Dispose should be called. So this is not the return value, which is true when the streams were disposed.
I'll try to make it similar to the other methods, please wait for the next commit.
Collaborator
Author
|
Is this better now? |
Owner
|
Thanks looks better now |
justcoding121
added a commit
that referenced
this pull request
Oct 18, 2017
move Dispose calls to finally blocks
justcoding121
added a commit
that referenced
this pull request
Oct 18, 2017
move Dispose calls to finally blocks
justcoding121
added a commit
that referenced
this pull request
Oct 19, 2017
move Dispose calls to finally blocks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doneness: