Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

Conversation

@honfika
Copy link
Collaborator

@honfika honfika commented May 17, 2017

…and IsRootCertificateMachineTrusted)

Allow to machine trust the root certificate (it will show the UAC dialog when required)

Doneness:

  • Build is okay - I made sure that this change is building successfully.
  • No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of.
  • Branching - If this is not a hotfix, I am making this request against develop branch

…and IsRootCertificateMachineTrusted)

Allow to machine trust the root certificate (it will show the UAC dialog when required)

var info = new ProcessStartInfo
{
FileName = "certutil.exe",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Local Machine is what we need instead of Enterprise? I think if we don't specify -Enterprise it installs for local machine.

Copy link
Collaborator Author

@honfika honfika May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telling the truth I don't know what is the difference. I tried it with -Enterprise argument and it did not add to the "Enterprise Trust". It added to the "Trusted Root CA" for local machine.
Without the argument the result is the same. So you are right, it is better to remove that parameter.
I have a domain joined Windows 10 machine.

This solution works only on Windows, but if we make a small executable file which just imports the certificate and embedding it to TWP as an embedded resource, it can also work on another OS. What do you think about it? Would you mind if I create a small project and add the complied assembly to the TWP project as an embedded resource (of course the repository will contain only the source, so I won't upload harmful binary files:))?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of embedding at least for now. We can add a link to the exe (may be separate repository) in our readme & wiki, and if it got considerable use we can import it to this repo.

Having said that I am not sure how an exe would work in Linux or Mac since they have different extensions for executable if I recall correctly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Linux an executable file can have any extension. So it will work with .exe extension, too. But I don't know how the certificates are working on Linux, maybe on Linux no elevated permission is needed for trusting the a root certificate for Firefox. I don't have Linux and my program which uses TWP is not working on Linux, so for me it is not a problem:)

@justcoding121 justcoding121 merged commit 78746e8 into justcoding121:develop May 17, 2017
justcoding121 added a commit that referenced this pull request Oct 18, 2017
Allow to query the root certificate status (IsRootCertificateTrusted …
justcoding121 added a commit that referenced this pull request Oct 18, 2017
Allow to query the root certificate status (IsRootCertificateTrusted …
justcoding121 added a commit that referenced this pull request Oct 19, 2017
Allow to query the root certificate status (IsRootCertificateTrusted …
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants