This repository was archived by the owner on Jul 9, 2023. It is now read-only.
Memory Leak Fix #580
Merged
Memory Leak Fix #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for an unknown reason. In any case, this code is easier to read.
justcoding121
approved these changes
Apr 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doneness:
For an unknown reason, previous code with "continue" generated a memory leak on TcpServerConnection 'connection'. Removing continue helped to fix (an other way was to set connection=null). In any case, this code is easier to read and fix the memory leak.
As the leak was TcpServerConnection , CustomBufferedStream was also retained...
(Memory Leak was present with .net 4.5)