Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

Conversation

@honfika
Copy link
Collaborator

@honfika honfika commented Apr 27, 2019

Doneness:

  • Build is okay - I made sure that this change is building successfully.
  • No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of.
  • Branching - If this is not a hotfix, I am making this request against the master branch

known issues:

  • some http/2 validation is not enforced
  • generated header is always 1 frame (can be bigger than a valid frame size), however I never saw any splitted header, yet
  • copyHttp2FrameAsync method looks ugly, especially the encoding part, long

@honfika honfika merged commit 6a18615 into justcoding121:master Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants