Support Ruby 3.4 #26
Merged
Support Ruby 3.4 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
reviewed
Jan 7, 2025
larouxn
force-pushed
the
ruby_3.4_support
branch
from
9012527 to
5a2962c
Compare
|
FYI, have been running this branch in production on Ruby 3.4.1 without issue for a day or so now. |
|
👋 @anakinj, is this something you'd be able to look into reviewing, merging, and releasing? (tagging as I see you've been active over in jwt/ruby-jwt) |
|
Hi. I'd love to help but I don't currently have powers to merge or release the jwe gem. I'll reach out to @francescobbo to see if he would be willing to extend the powers a bit. |
|
@larouxn Could you be so kind and rebase your branch. Now I have powers and did a little refresh on the CI. |
The warning that appears without this change is: warning: base64 was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0. You can add base64 to your Gemfile or gemspec to silence this warning.
Co-authored-by: Étienne Barrié <etienne.barrie@gmail.com>
larouxn
force-pushed
the
ruby_3.4_support
branch
from
5a2962c to
7ebed8a
Compare
|
👋 @anakinj, sure thing! Just rebased on latest Additionally noting that this PR fixes the Ruby 3.4 CI failure on master as shown here in branch CI. |
anakinj
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I'm not that familiar with this gem. Simply trying to address Ruby 3.4 issues as it will be released in a few days and the amount of warning messages when running our application on Ruby 3.4 is quite large. Thankfully the fixes seem pretty straightforward.
base64to the Gemspec as a runtime dependency as it's no longer a default gem as of Ruby 3.4.frozen_string_literal: truedirective anddupall strings that we attempt to modify in place withforce_encodingas in place string modification is forbidden with said directive in place.Resolves #25