Support Partial Indexes syntax(PostgreSQL) #41
Merged
k0kubun merged 4 commits intosqldef:masterfrom Oct 3, 2019
Merged
Conversation
yudppp
commented
Oct 1, 2019
| return false | ||
| } | ||
| } | ||
| if indexA.where != indexB.where { |
Contributor
Author
There was a problem hiding this comment.
This expression is not thorough.
For example, age > 20 and 20 < age deal with different expression.(Should be like same)
Should I support this case?
Collaborator
There was a problem hiding this comment.
It'd be nice to have for sure, but I think it's not critical because it's already usable in a normal way (if we don't attempt refactoring, etc.) and we can add the support later when we want.
yudppp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Partial Indexes syntax.
example
https://www.postgresql.org/docs/9.4/indexes-partial.html