Skip to content

Conversation

@berry120
Copy link

@berry120 berry120 commented Feb 5, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make?

Currently the maximum width of 110px in the left-hand menu is really conservative, dropping way more text than it needs:

image

160px seems like a much better choice:

image

Much more text is shown now, but it still cuts off appropriately before the drop-down icon.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@berry120 berry120 requested a review from a team as a code owner February 5, 2025 09:48
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 5, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi berry120! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Mgrdich
Copy link
Contributor

Mgrdich commented Feb 12, 2025

@Haarolean this needs to be discussed with the designer

@Haarolean
Copy link
Member

@Haarolean this needs to be discussed with the designer

yeah I believe we had a solution for long cluster names

@Haarolean
Copy link
Member

Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our design, the sidebar width currently is 240px. The issue with long cluster names should be solved using this design approach rather than this hammer fix.
P.S. Please note that there has been another PR open on this matter (#727), I left the same comment there.

@kapybro
Copy link

kapybro bot commented Feb 28, 2025

Further user feedback is requested. Please reply within 7 days or we might close the issue.

@berry120
Copy link
Author

@Haarolean Are you referring to this approach where the text is wrapped?

{03FB206F-D44F-47CB-B8FE-FE4B7C120A0C}

If so then the wrapping looks much better to me (is this coming in the next release?) but even in this design it still looks like there's some wasted whitespace on the right hand side that could be used to avoid as much wrapping?

@kapybro
Copy link

kapybro bot commented Feb 28, 2025

Thanks for the additional feedback! We'll get back to your issue soon.

@Haarolean
Copy link
Member

@Haarolean Are you referring to this approach where the text is wrapped?

{03FB206F-D44F-47CB-B8FE-FE4B7C120A0C}

If so then the wrapping looks much better to me (is this coming in the next release?) but even in this design it still looks like there's some wasted whitespace on the right hand side that could be used to avoid as much wrapping?

I believe it's to have a decent breathing space before the dropdown arrow, but I'll inquire our designer @snoorge about this

@Haarolean Haarolean self-assigned this Aug 15, 2025
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 5, 2025
@germanosin
Copy link
Member

There have been a number of updates on this. Could you please check the latest main tag? I think we can close it.

@berry120
Copy link
Author

berry120 commented Nov 8, 2025

Yeah main looks much better now as-is, thanks!

@berry120 berry120 closed this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants