Cleanup code duplicated between Server0P9P0 and Server0P8P2. #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantswain
requested changes
Jan 13, 2017
Collaborator
dantswain
left a comment
dantswain
left a comment
There was a problem hiding this comment.
Could use some comments to help the reader navigate the code, otherwise nice cleanup! Should increase code coverage as well!
| GenServer.start_link(__MODULE__, [args, name], [name: name]) | ||
| end | ||
|
|
||
| defdelegate kafka_server_consumer_group(state), to: Server0P8P2 |
Collaborator
There was a problem hiding this comment.
May be worth adding a comment here to the effect that the implementation for these is the same in 0.9.0 as it is in 0.8.2?
Member
Author
|
@dantswain does the comment look good? |
dantswain
approved these changes
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.