removed typo from docs #382
Conversation
|
Hello, @TonyDMorris! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
|
|
||
| - Github: | ||
| [new_api.md](https://github.com/kafka_ex/kafkaex/blob/master/new_api.md) | ||
| - HexDocs: [New API](new_api.html) |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| * HexDocs: [New API](new_api.html) | ||
| For more information on the v1.0 API, see | ||
|
|
||
| - Github: |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
|
|
||
| For more information on the v1.0 API, see | ||
| - Github: [kayrock.md](https://github.com/kafka_ex/kafkaex/blob/master/kayrock.md) | ||
| - HexDocs: [kayrock-based client](kayrock.html) |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| * HexDocs: [kayrock-based client](kayrock.html) | ||
|
|
||
| For more information on the v1.0 API, see | ||
| - Github: [kayrock.md](https://github.com/kafka_ex/kafkaex/blob/master/kayrock.md) |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| - The new client should be compatible with existing code when used this way. | ||
| - Many functions now suppoert an `api_version` parameter, see below for details, | ||
| e.g., how to store offsets in Kafka instead of Zookeeper. | ||
| - Version 1.0 of KafkaEx will be based on Kayrock and have a cleaner API - you |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| - This is new implementation and we need people to test it! | ||
| - Set `kafka_version: "kayrock"` to use the new client implementation. | ||
| - The new client should be compatible with existing code when used this way. | ||
| - Many functions now suppoert an `api_version` parameter, see below for details, |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| See below for details. | ||
| - This is new implementation and we need people to test it! | ||
| - Set `kafka_version: "kayrock"` to use the new client implementation. | ||
| - The new client should be compatible with existing code when used this way. |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| can start testing this API by using modules from the `KafkaEx.New` namespace. | ||
| See below for details. | ||
| - This is new implementation and we need people to test it! | ||
| - Set `kafka_version: "kayrock"` to use the new client implementation. |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| * Version 1.0 of KafkaEx will be based on Kayrock and have a cleaner API - you | ||
| can start testing this API by using modules from the `KafkaEx.New` namespace. | ||
| See below for details. | ||
| - This is new implementation and we need people to test it! |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| - Message Compression with Snappy and gzip | ||
| - Offset Management (fetch / commit / autocommit) | ||
| - Consumer Groups | ||
| - Topics Management (create / delete) |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| - Fetch Messages | ||
| - Message Compression with Snappy and gzip | ||
| - Offset Management (fetch / commit / autocommit) | ||
| - Consumer Groups |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| - Produce Messages | ||
| - Fetch Messages | ||
| - Message Compression with Snappy and gzip | ||
| - Offset Management (fetch / commit / autocommit) |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| - Broker and Topic Metadata | ||
| - Produce Messages | ||
| - Fetch Messages | ||
| - Message Compression with Snappy and gzip |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| * Topics Management (create / delete) | ||
| - Broker and Topic Metadata | ||
| - Produce Messages | ||
| - Fetch Messages |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| * Consumer Groups | ||
| * Topics Management (create / delete) | ||
| - Broker and Topic Metadata | ||
| - Produce Messages |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
| * Offset Management (fetch / commit / autocommit) | ||
| * Consumer Groups | ||
| * Topics Management (create / delete) | ||
| - Broker and Topic Metadata |
There was a problem hiding this comment.
Incorrect list-item indent: add 2 spaces
|
SourceLevel has finished reviewing this Pull Request and has found:
You can see more details about this review at https://app.sourcelevel.io/github/kafkaex/kafka_ex/pulls/382. |
1 participant
small typo in the response struct returned by fetch latest offset