-
Notifications
You must be signed in to change notification settings - Fork 5
Allows users to optionally set kagi.com as their default new tab page (new tab page override etc) #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need storage permission to store users new tab choice. Additionally need tabs permission to override new tab page with kagi.com if user selected this option.
Simple get/set storage for the users new tab choice
Handles the actual overriding of new tab page in Chrome. Implemented as an optional change, letting the user decide, hence the check for "chrome://newtab/" and the storage key
Very simple, simply set the href of the new tab page. Note that if I followed the Chrome docs on overriding the new tab page, we wouldn't be able to give users the choice to opt-in or opt-out of this feature
|
Hello Kagi team, just checking in :) any chance this would be merged? I’m rocking it locally currently with no issues! Also wondering if you have any other extensions planned in the future, how about a sidepanel extension for chrome for a global search panel? Would love to contribute more Thank you, |
|
Hi there @con-dog, sorry for the wait. This looks fine, but one thing that I would rather we not do is use the "tabs" permission, at least not as a 'default' permission. We previously had this permission set on our extensions and it was not received well (kagisearch/browser_extensions#13) & (kagisearch/browser_extensions#17) There is an This makes it so that it requires an explicit user confirmation that they want to enable this permission and doesn't always require it and it doesn't show up in the "permissions" section of the extension. We use this optional permissions in our other repository which hosts the firefox (and old chrome) extension, for Does that make sense & sound good to you? |
|
Hi @PixeLInc no problem :) Good call on it not being received well. I will play around with optional_permissions for both storage and tabs. Sounds really good to me, I will post an update tomorrow :) Cheers, |
|
Have made those changes @PixeLInc , managed to get it down to just 1 optional_permission "tabs" |
|
Hey there @con-dog, Unfortunately after looking into it further, it appears that this feature actually is explicitly not allowed as per chrome store guidelines... https://developer.chrome.com/docs/webstore/program-policies/api-use If we were to want to do this, we'd have to always override the new tab page with a markup file and redirect from there (which is how other extensions that do this do it), but at that point it becomes not optional and more complicated (and also, that feels a little dodgy too). So! Due to that, unfortunately we can't add this as to not break those rules. Sorry about all that, I did not realize this was the case originally otherwise I would've mentioned it right away. |
|
Hey @PixeLInc no worries, thats a shame that chrome don't allow this functionality. I agree an alternative approach would be too hacky to implement, and its not worth the risk of getting taken down. |

What it does
Adds the ability for a user to optionally set kagi.com as their default new tab page, toggling the setting via a checkbox in the popup panel
Why ?
Improves the UX flow of using Kagi as your default search engine. By always opening a new tab to Kagi.com, a user gets a better search experience. Additionally the "Assistants" are more readily accessible via kagi.com
Implementation Details
Testing
Reasons against merging
Screenshots