workflow: Use bash to fail fast #18
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the fetching script fails, the step will be green because there's no fail-fast behavior with the default GHA shell. For example: https://github.com/kata-containers/kata-containers.github.io/actions/runs/11674542121/job/32507427396 So we switch to an explicit bash to address this and fail the entire run (see docs linked in code). Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
a1icja
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the fetching script fails, the step will be green because there's no fail-fast behavior with the default GHA shell. For example:
https://github.com/kata-containers/kata-containers.github.io/actions/runs/11674542121/job/32507427396
So we switch to an explicit bash to address this and fail the entire run (see docs linked in code).