Sentry integration #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sentry config to index.js Add sentry to redux store using middleware Add sentry error reporting to api calls in httpFetch.js Add sentry error reporting in Home.jsx Create new 'lib/util.js' file to provide sentry error specific data
Pull Request Test Coverage Report for Build 22
💛 - Coveralls |
Kameshwaran
reviewed
Apr 2, 2018
| console.error(err); | ||
| }).catch((err) => { | ||
| console.error(err); | ||
| Raven.captureException(err, sentryExtra('Error while fetching user Info')); |
There was a problem hiding this comment.
How are you communicating this error to the user?
When the getUserInfo API call fails, how are you intimating the user that 'data retrieval' from the server is failed?
You are registering the exceptions with Raven which is just going to track the exception on Sentry Dashboard. But, it seems nowhere we are showing the error message to the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.