Fix algorithm selection not persisting from URL query parameters #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed a bug introduced with the URL params saving feature: when opening a shared URL with
algoandprocessesparameters (e.g.,?algo=SRTF&processes=[...]), the algorithm parameter was being dropped from the URL and the algorithm dropdown remained unselected.It appears that the URL update effect rebuilt search params from scratch before the form initialized with URL values, causing the
algoparameter to be dropped during React hydration. It weirdly wasn't happening when I tested locally, but it's now fixed.Fix
defaultValuesthat read from URL params synchronouslywindow.location.searchinstead of empty URLSearchParamsselectedAlgorithmstate with form value via dedicated effectIt should all work properly now. Take your time to review this, and let me know if you notice any issues.
Thanks for your patience with all the PRs, this should be the last one 😅