Skip to content

Conversation

@MrCreosote
Copy link
Member

That was a major pain.

  • deleting a topic & contents takes ~2s locally, tripled test time when
    run after every test
  • Kafka consumer polling is pretty slow, and can't be done mid test if
    assert _close_to_now is used.
  • It seems as though not closing clients can cause weird errors/hangs in
    other clients? Not 100% sure about this, was making too many changes
    too rapidly trying to figure out what was going on. Closing doesn't seem
    to hurt though.

also flake8 mysteriously started whining about new stuff even though it
wasn't updated.

That was a major pain.
* deleting a topic & contents takes ~2s locally, tripled test time when
  run after every test
* Kafka consumer polling is pretty slow, and can't be done mid test if
  assert _close_to_now is used.
* It seems as though not closing clients can cause weird errors/hangs in
  other clients? Not 100% sure about this, was making too many changes
  too rapidly trying to figure out what was going on. Closing doesn't seem
  to hurt  though.

also flake8 mysteriously started whining about new stuff even though it
wasn't updated.
@MrCreosote
Copy link
Member Author

coveralls seems to sometime count a line in the storage file as covered, and sometimes not, leading to weird coverage changes when the file and its tests aren't touched

@MrCreosote MrCreosote merged commit ceb0039 into kbase:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant