Skip to content
This repository was archived by the owner on Feb 25, 2020. It is now read-only.

Pull Requests

Cyrus Raitava-Kumar edited this page Mar 24, 2019 · 13 revisions

Pull Requests

To navigate to the PRs, use this link

Pull Request Process

All pull requests should follow a common template setup, they should also cover all criteria in the pull request checklist (unless otherwise specified).

Pull Request Checklist

  • Latest master merged into your branch
  • Tests covering all changes
  • Meet the projects coding conventions
  • No out of scope changes

Pull Request Template

  • Reference the issue your pull request is related to, use a keyword so that the issue is automatically closed when the pull request is merged.
  • Brief outline of changes and how you have solved the issue or implemented a feature.
  • Any specific notes for reviewers (e.g. if you require testing on a different OS)

Required Reviewers

Pull requests require a minimum of one person to review. When the person reviewing approves the changes, it is their job to merge the PR into master.

Actual Used Template


Related Issue/Keyword:

Description: Enter description of PR here. Any decisions (design or otherwise) made, that another developer may question should be put and summarised here. Any related issues/PRs should also be included here (e.g what it may close/resolve).

  • [] Latest master merged/rebased into your feature branch
  • [] Tests covering all changes
  • [] Meet the projects coding conventions
  • [] No out of scope changes
  • [] Included a relevant gif (search here for inspiration)

![](insert gif link between braces here)


Note: If you're the code author in the PR. Once your code has been approved and merged, the branch the feature was developed on is to be deleted.

Clone this wiki locally